[redesign][governance] proposal details view. #3345

amass01 · 2021-03-29T15:55:21Z

Main changes:

Split ProposalsDetials.module.css helpers styling into components own css modules.
Add vote end event & blocks left number.
Define proposal status & vote status as constants.
Add Join component to display subtitle separated fields.
Add global helper css classes.
Ditch OverviewField component.
Replace EligibleTickets component with new VoteSection.
Delete TxHsitory/EligibleRow.jsx and it's styling.
Move Vote Pref. component to VoteSection according to new specs.
Improve viewedProposal state obj to avoid duplicated fields.
Declarative Proposals Details Page helpers.
Replace shared classes with new components (ie VoteButton & NoTicketsMsg)
Finish Vote Preference section & introduce VotedCheckmark.
Rename ChooseOptions component to VotePreference.
Rename ChooseVoteOption to VotePreferenceWrapper.
Move CastVoteModalButton to a separate dir with css module.
Tweak proposal body & politeia proposal button/link.
Re-arrange proposal card.
Tweak subtitle.
Add proposal card back button.
Add title tooltip.

Note: before reviewing the code I'd suggest comparing components/viewed/ProposalDetailsPage dir and it's structure on master and on this branch.

Screenshots:

Voting proposal & user voted:

Abandoned:

Rejected:

Closes #3288.

amass01 · 2021-04-05T00:27:31Z

Tested and found two issues:

Approved proposals showing currently rejected status tag.
Minor alignment issue in vote section:

amass01 · 2021-04-05T00:32:17Z

Note: This was implemented & tested against pre-tlog poltieia code, I'll address the two issues listed above
and then will test it against latest politeia commit and see how it plays.

amass01 · 2021-04-05T01:00:50Z

app/components/views/ProposalDetailsPage/ProposalDetailsPage.jsx

@@ -32,18 +32,19 @@ const ProposalDetailsPage = () => {
          </div>
        );
      case "success":
+        // XXX this should move to redux logic, we should parse proposal body


will followup with a PR for this XXX

...components/views/ProposalDetailsPage/helpers/VotePreferenceWrapper/VotePreferenceWrapper.jsx

amass01 · 2021-04-05T01:01:45Z

app/constants/index.js

@@ -1,5 +1,7 @@
+// XXX change all files to small letters!


will followup with this change.

amass01 · 2021-04-05T01:18:33Z

Tested and found two issues:

1. Approved proposals showing currently rejected status tag.

2. Minor alignment issue in vote section:
   ![image](https://user-images.githubusercontent.com/10324528/113525647-d2ecef00-95be-11eb-9fe5-9106c4dad5fa.png)

Looks like BE returns in votesummary approved: false for the proposal in the screenshot, others have the right
approved tag with latest commit:
Improved.

amass01 · 2021-04-05T02:05:53Z

Need few last touches in smaller screens.

alexlyp · 2021-04-05T18:08:40Z

Needs a rebase

- Deletes TxHsitory/EliginleRow.jsx and it's styling. - Moves Vote Pref. component to VoteSection according to new specs. - Improves viewedProposal state obj to avoid duplicated fields. - Introduces ChooseVoteOption.module.css

…odules . + Declarative Proposals Details Page helpers. + ChooseOptions.module.css + VoteButton.module.css + Replace shared classes with new components ie VoteButton & NoTicketsMsg

define proposal status & vote status as constants.

- add global helper css classes - ditch OverviewField - re-arrange proposal card

amass01 · 2021-04-05T21:29:07Z

@alexlyp rebased & improved smaller screens as well.

alexlyp · 2021-04-05T21:36:46Z

Getting an error when I go to the top result in the Finished category (Underwater Citadel):
hooks.js:16 Uncaught TypeError: Cannot destructure property 'viewedProposalDetails' of 'undefined' as it is undefined.

This wallet has no live tickets currently if that helps reproduce.

amass01 · 2021-04-05T21:53:22Z

@alexlyp updated

alexlyp · 2021-04-06T16:33:14Z

Seeing some text in dark theme show as white on white. Voting power and the short hash below the status on the proposal details page

amass01 force-pushed the proposaldetail branch 8 times, most recently from e70d902 to c464813 Compare April 2, 2021 23:56

amass01 changed the title ~~[WIP][redesign] Governance: proposal details view.~~ [redesign][governance] proposal details view. Apr 5, 2021

amass01 commented Apr 5, 2021

View reviewed changes

...components/views/ProposalDetailsPage/helpers/VotePreferenceWrapper/VotePreferenceWrapper.jsx Outdated Show resolved Hide resolved

amass01 commented Apr 5, 2021

View reviewed changes

app/constants/index.js

@@ -1,5 +1,7 @@

// XXX change all files to small letters!

Copy link

Member Author

amass01 Apr 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will followup with this change.

amass01 added 13 commits April 6, 2021 00:24

- Replaces EligibleTickets component with new VoteSection.

09a2643

- Deletes TxHsitory/EliginleRow.jsx and it's styling. - Moves Vote Pref. component to VoteSection according to new specs. - Improves viewedProposal state obj to avoid duplicated fields. - Introduces ChooseVoteOption.module.css

+ Split ProposalsDetials.module.css into helpers components own css m…

f71bdeb

…odules . + Declarative Proposals Details Page helpers. + ChooseOptions.module.css + VoteButton.module.css + Replace shared classes with new components ie VoteButton & NoTicketsMsg

Finish Vote Preference section & introduce VotedCheckmark

5354c4c

rename ChooseOptions component to VotePreference

04b72b9

rename ChooseVoteOption to VotePreferenceWrapper

b58b1db

move CastVoteModalButton to a separate dir with css module.

de846d8

tweak proposal body & politeia proposal button/link.

69ac17b

add vote end event & blocks left number.

f31d752

define proposal status & vote status as constants.

- add Join component to display subtitle separated fields

e41cabc

- add global helper css classes - ditch OverviewField - re-arrange proposal card

tweak proposal card subtitle

77725a5

add proposal card back button

552574f

Add title tooltip

2166be5

polish proposal card

a396070

amass01 added 5 commits April 6, 2021 00:24

finish moving helpers css to their own css modules.

0c060a8

polish stakey indicator alignment

337c205

polish StatusTag & self review

6301344

linter

767a487

introduce useVotePreference

33e46f4

amass01 force-pushed the proposaldetail branch from 660dff9 to e01aa87 Compare April 5, 2021 21:27

smaller screens love

894e83c

amass01 force-pushed the proposaldetail branch from e01aa87 to 894e83c Compare April 5, 2021 21:52

polish no tickets empty message

bfdc493

amass01 force-pushed the proposaldetail branch from e30d9c5 to bfdc493 Compare April 5, 2021 22:53

dark theme highlighted text & back button hover effect

2f37cc6

alexlyp approved these changes Apr 6, 2021

View reviewed changes

alexlyp merged commit 23da0b8 into decred:master Apr 6, 2021

amass01 deleted the proposaldetail branch April 6, 2021 22:03

amass01 mentioned this pull request Apr 8, 2021

[governance] parse & store proposal's body on redux level. #3370

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[redesign][governance] proposal details view. #3345

[redesign][governance] proposal details view. #3345

amass01 commented Mar 29, 2021 •

edited

amass01 commented Apr 5, 2021

amass01 commented Apr 5, 2021

amass01 Apr 5, 2021

amass01 Apr 5, 2021

amass01 commented Apr 5, 2021

amass01 commented Apr 5, 2021

alexlyp commented Apr 5, 2021

amass01 commented Apr 5, 2021

alexlyp commented Apr 5, 2021

amass01 commented Apr 5, 2021

alexlyp commented Apr 6, 2021

[redesign][governance] proposal details view. #3345

[redesign][governance] proposal details view. #3345

Conversation

amass01 commented Mar 29, 2021 • edited

amass01 commented Apr 5, 2021

amass01 commented Apr 5, 2021

amass01 Apr 5, 2021

Choose a reason for hiding this comment

amass01 Apr 5, 2021

Choose a reason for hiding this comment

amass01 commented Apr 5, 2021

amass01 commented Apr 5, 2021

alexlyp commented Apr 5, 2021

amass01 commented Apr 5, 2021

alexlyp commented Apr 5, 2021

amass01 commented Apr 5, 2021

alexlyp commented Apr 6, 2021

amass01 commented Mar 29, 2021 •

edited