Disabled Dex menu with tooltip in SPV mode #3505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall looks pretty good! Couple things that stand out: While in Dark tonality, it's hard to read DEX in the sidebar. Light looks great. I think it reads better as "DEX not available while using SPV. Please go to settings and disable SPV to access the DEX." |
|
@alexlyp Thanks for the review. I pushed the fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff implements @jholdstock's idea on the matrix: "Maybe decrediton in SPV mode should just gray out the Dex tab, with a tooltip to explain that SPV needs to be switched off. Hiding it completely has caught a lot of people out)"