[wallet] Use BrowserView ConfirmDialog on SignTx #3519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgptr
approved these changes
Jun 28, 2021
matheusd
force-pushed
the
confirm-sign-tx
branch
from
a6af24f
to
599c0f5
Compare
This ensures UI code does not have the ability to change the tx to be signed before it is passed to the wallet.
matheusd
force-pushed
the
confirm-sign-tx
branch
from
599c0f5
to
a2e1bca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #3515This switches the wallet's
SignTxfunction to confirm with the user the transaction to be signed via the recently introduced confirmation dialog that runs in a BrowserView.This ensures that any attempts by UI code to modify the transaction are visible to the user before the tx is sent to the underlying wallet to be signed.
The dialog is formatted such that only outputs and amounts that are not returning to the wallet (i.e. addresses in outputs that do not correspond to one of the wallet's BIP0044 account) are shown.