[Wallet] Confirm seed via BrowserView dialog #3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
force-pushed
the
confirm-seed
branch
2 times, most recently
from
09959b1
to
d88e3ae
Compare
alexlyp
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #3519
This adds a final confirmation window to the wallet creation flow which displays the seed that is about to be used to create the wallet via the recently introduced, BrowserView based confirmation dialog.
This prevents UI code from tampering with the seed without user acknowledgement.
Seeds that are exactly 256 bits long (standard decred seeds) are displayed with the usual 33 word mnemonic sequence. Seeds of different length are displayed as raw hexadecimal.
Please note that rejecting the seed currently breaks wallet setup. This is not specifically related to this PR, but rather the fact that any errors during the final wallet setup aren't being correctly handled right now. This will need to be fixed in a separate PR.
Thanks to @vctt94 for some help in fixing the reject flow.