Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[redesign][ln] Receive tab #3537

Merged
merged 23 commits into from Aug 10, 2021
Merged

[redesign][ln] Receive tab #3537

merged 23 commits into from Aug 10, 2021

Conversation

bgptr
Copy link
Collaborator

@bgptr bgptr commented Jul 21, 2021

Toward issue #3296

Some notes:

  • show settle date on invoice modal instead of expiration time when the payment already has been received
  • cancel invoice feature added
  • add snackbar messages for indicating add and cancel invoice events
  • implemented filter, sort, and search function for invoice list
  • tests added

Updated screenshots:
DeepinScreenshot_select-area_20210809215032
DeepinScreenshot_select-area_20210805140422
DeepinScreenshot_select-area_20210809214956

Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going in the right track, but I see some UX issues:

  • You can't create a 0 amount invoice anymore. This is needed for "donations" (a 0 amount invoice indicates the sender can send any amount)
  • Both canceled and timed out invoices are appearing as "canceled" (not sure that's the intention)
  • Maybe we should disable copying the payment request if the payment was canceled/timed out? It will fail if someone attempts to pay for it, so this could make it less prone to cause this error
  • Amount in the individual invoice box (in the invoices listing) is showing a "+" sign
  • I'd like to get an additional expandable view (either in the details modal or directly in the listing) with the extended info for the invoice (hash, description, htlcs, etc).

@bgptr bgptr mentioned this pull request Jul 23, 2021
@bgptr
Copy link
Collaborator Author

bgptr commented Aug 1, 2021

@matheusd Thanks for your review. I've pushed the suggested changes and updated the screenshots.

@bgptr
Copy link
Collaborator Author

bgptr commented Aug 5, 2021

Update: implemented the polished details part of the invoice modal thanks to @MariaPleshkova. (screenshots are updated)
Also, converted the details table to a shared component since more of the ln pages will use it.

Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it's probably useful to have the payment hash be copyable, since that's used in the command line to verify things.

@MariaPleshkova
Copy link

@bgptr
I added the copy button next to the hash as @matheusd suggested. We already use the same button for the Remote Pubkey in the Channel Properties.
image

@bgptr
Copy link
Collaborator Author

bgptr commented Aug 9, 2021

@matheusd @MariaPleshkova Thanks, guys. I pushed the changes and updated the screenshots.

Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working nicely now!

@alexlyp alexlyp merged commit bf33f9c into decred:master Aug 10, 2021
@bgptr bgptr deleted the ln-redesign-receive branch August 27, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants