New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[redesign][ln] Send tab #3538
[redesign][ln] Send tab #3538
Conversation
c4b370d
to
0f066ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel you need to show more info about the decoded payment request. At the very least, you need to show the payment hash, description and the expiry.
Showing the extended details (ctlv expiry, fallback onchain address, etc) could be added in an expanded view.
It would probably be helpful to have the destination node use the copyable component as well.
You should also block attempting to pay for expired invoices (while the node will ultimately reject the payment attempt, it's better to also do it in the earliest stage possible, with feedback to the user of what's going on).
- copyable destination - add expiry and description fields - block expired invoices to pay
Thanks, @matheusd. I've added the suggested details and blocked attempting to pay for expired invoices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Only two additional nits.
app/components/views/LNPage/SendTab/DecodedPayRequest/helpers.js
Outdated
Show resolved
Hide resolved
app/components/views/LNPage/SendTab/DecodedPayRequest/DecodedPayRequest.jsx
Outdated
Show resolved
Hide resolved
@matheusd, thanks. I've pushed the changes. |
26d8a36
to
ed97e24
Compare
@bgptr generally looks good, but a few small tweaks from my side:
|
@bgptr and check the spacings within Lightning Payment Request Code, please. They should be 10px from all sides: |
- fix padding of the CopyableText - improve req code textinput (hide icons) - improve decoded pay request form
@MariaPleshkova, thanks for the review. I've implemented your suggestions and updated the screenshots. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final typo, but otherwise LGTM.
Toward issue #3296
This diff updates only the header and the send form. I did not touch the history lists (Ongoing payments, Failed payments, Latest payments) since the design doesn't contain them.update: @MariaPleshkova has added the list to the Figma designs, and this diff implements it.
Updated screenshots: