Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error flows in create wallet #3554

Merged
merged 1 commit into from Sep 17, 2021

Conversation

bgptr
Copy link
Collaborator

@bgptr bgptr commented Sep 12, 2021

Closes #3524

Found and fixed these errors in create wallet flow:

  1. rejecting the final confirmation dialog (or receiving an error from the wallet create request) at the final stage of creation/restore wallet jumps back to the create/restore view (PreCreateWallet) and displays an error: loader.OpenExistingWallet: item does not exist:: wallet.OpenDB: missing database file. The wallet is partially created and started but until the restart of the app, it can not be stopped or start any other wallet.
  2. when an app refresh breaks the creation/restore process, a similar thing happens. The partially created/restored wallet is running in the background and it can not be stopped or start any other wallet.
  3. the flashing wallet selection screen after creating a wallet is also fixed. It is mentioned here: https://github.com/decred/decrediton/blob/c46d2f8e0fe40cebf16cecab1adb3b6056775bca/test/unit/components/views/GetStaredPage/PreCreateWallet.spec.js#L363/L365

Copy link
Member

@matheusd matheusd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this! This was a really annoying behavior.

Tested the listed situations.

@alexlyp alexlyp merged commit d7461a8 into decred:master Sep 17, 2021
@bgptr bgptr deleted the fix-error-flows-in-create-wallet branch January 17, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix error flows in create wallet
3 participants