TransactionAction and Txdetails improvements #3789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update recentStakeTransactions on getTicketStatus request +add tests
bgptr
force-pushed
the
txdetails-improvements
branch
from
4fb53d6
to
29eb173
Compare
alexlyp
approved these changes
Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff cleans and adds detailed tests for TransactionActions, and TransactionPage.
Builds on top of #3778
Closes #3689
Also, it improves the Transaction details view:
show the correct plural address label on the tx details view. (To address: vs. To addresses: )
Stakebase transactions (votes) have only one (
stakebase) non-wallet output.fix block display and URL on tx details view. before/after:
Spending Txon the tx details view:Solothough it is paid (or in another fee status). This diff fixes it: before/after