[DEX] Auto update wallet passphrase on update private passphrase #3822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgptr
force-pushed
the
dex-wallet-update
branch
from
67bc35d
to
021e1da
Compare
|
From my testing on this PR i'm still hitting the issue. I see the new Dex App Password field, and I see it building a fresh go build for dexc on install, so not sure what the problem is |
|
Do you see a successful |
bgptr
force-pushed
the
dex-wallet-update
branch
from
021e1da
to
5ce1879
Compare
|
Hrm not seeing that action fire at all. Let me confirm I'm on the correct commit etc |
|
Yah just confirmed I am on that commit and see the actions "DEX_SETWALLET..." in the code. But not seeing any of those fire on private passphrase change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3820
Builds on top of #3800
This diff introduces an additional DEX app password input on the private passphrase modal if DEX is active.
If the user provides the DEX app password, the app automatically propagates the changes to
dexctoo