[launcher] Speed up opening the wallet #3846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ remove gettingVSPInfo step from the setup view process + fix loading status on process manages/unmanaged views + cleanup process managed and unmanaged tickets + add tests
alexlyp
approved these changes
Apr 6, 2023
alexlyp
pushed a commit
that referenced
this pull request
Apr 6, 2023
+ remove gettingVSPInfo step from the setup view process + fix loading status on process manages/unmanaged views + cleanup process managed and unmanaged tickets + add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3843
This removes the unnecessary
gettingVSPInfostep from the setup wallet process. The fetched vsp info is used only in the manage processed tickets part of the flow. Now it's requested only if needed.Also, this diff cleans up the process managed and unmanaged views and adds tests for them.