Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cms] Peer review line items based on their domain, not account domain #1346

Closed
xaur opened this issue Dec 14, 2020 · 1 comment · Fixed by #1351
Closed

[cms] Peer review line items based on their domain, not account domain #1346

xaur opened this issue Dec 14, 2020 · 1 comment · Fixed by #1351
Assignees
Labels

Comments

@xaur
Copy link

xaur commented Dec 14, 2020

This issue is to change the current same-domain review visibility from the current rule

Users can see invoices of other users in the same domain

to

Users can see line items of the same domain as their account

Currently, if my domain is Marketing and another user with domain=Development submits a line item with domain=Marketing, I cannot review that line item, because I cannot see that invoice, because its submitter is in the different domain.

I suggest to change this visibility rule to compare my domain with line item domain regardless of what domain its submitter belongs to.

This change has some implications for the current system:

  • I will start seeing invoices that were not shown previously because their submitters are in different domains. I call these "surrogate" invoices because they are only necessary to have some container to place matching items.
  • I should stop seeing line items of domains other than mine.
@xaur
Copy link
Author

xaur commented Jun 6, 2021

Tested, currently bugged by #1424 but otherwise works as expected. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants