Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: Add comment versioning #970

Closed
lukebp opened this issue Aug 12, 2019 · 9 comments
Closed

multi: Add comment versioning #970

lukebp opened this issue Aug 12, 2019 · 9 comments
Labels
feature The issue adds a new feature.

Comments

@lukebp
Copy link
Member

lukebp commented Aug 12, 2019

It has become apparent that adding comment versioning would be a useful feature. There are multiple instances on pi of comments that were made erroneously or comments that have mistakes/typos in them. It would improve overall UX if a user is allowed to edit their comments.

This feature would be similar to how github comments work. A user would be allowed to edit their comment, but all prior versions of the comment would still be publicly viewable.

This will require changes to politeiad, politeiawww, and the cache. A rough outline of the work that would need to be done:

  • Add an edit action to the comment journals
  • Update the cache to store all versions of the comment
  • Add politeiawww routes for editing a comment and for fetching previous versions of a comment
@lukebp lukebp added the feature The issue adds a new feature. label Aug 12, 2019
@al-maisan
Copy link
Contributor

I'd be interested in tackling this if it's still open.

@lukebp
Copy link
Member Author

lukebp commented Sep 2, 2019

This issue is still open, buts a pretty big one. It will require significant changes to politeiawww, politeiad, and the cache. As a newcomer to the project, I'd prefer if you worked on some smaller issues first before tackling something like this.

@lukebp
Copy link
Member Author

lukebp commented Sep 3, 2019

@al-maisan are you on the decred matrix server?

@martonp
Copy link
Contributor

martonp commented Oct 3, 2019

@al-maisan are you working on this?

@al-maisan
Copy link
Contributor

Nope. See @lukebp 's comment above.

@martonp
Copy link
Contributor

martonp commented Oct 3, 2019

Ok I'll work on this one

@lukebp
Copy link
Member Author

lukebp commented Oct 3, 2019

@martonp this is a large issue. If you're going to tackle it you need to first post here how exactly you're going to do it and then break it up into smaller PRs that can be delivered individually.

@martonp
Copy link
Contributor

martonp commented Oct 4, 2019

@lukebp Sounds good, I'll do that.

@lukebp
Copy link
Member Author

lukebp commented Apr 29, 2021

Closing this issue due to inactivity or because it was included in the v1.0.0. If you feel this issue is still relevant, please re-open it to bring it to our attention.

@lukebp lukebp closed this as completed Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature The issue adds a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants