[totp] Add TOTP Code check in Login #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlyp
changed the title
alexlyp
force-pushed
the
ayp_totp_login
branch
from
b8acb86
to
7e7ba4c
Compare
alexlyp
force-pushed
the
ayp_totp_login
branch
from
35b8e22
to
b601b9a
Compare
alexlyp
force-pushed
the
ayp_totp_login
branch
from
8ef38e0
to
9d71e6f
Compare
lukebp
requested changes
Sep 9, 2020
lukebp
requested changes
Nov 25, 2020
alexlyp
force-pushed
the
ayp_totp_login
branch
from
bbd4c70
to
66edb29
Compare
|
OK updated with your suggestions @lukebp |
lukebp
approved these changes
Nov 25, 2020
marcopeereboom
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #1210This PR adds the ability to have users Login with TOTP if they have verified a TOTP Secret.
Currently, if a user has verified a TOTP then they will be told they need a code to be entered along with their username/password. This code must match before the hashed password is compare against what is saved in the database.
According to the implemented security measures here, we will only allow 2 failed TOTP codes to be submitted for a givien epoch. Any subsequent request will fail with a
ErrorStatusTOTPWaitForNewCode