-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
piwww: Add RFP process to testrun command. #1240
Conversation
Log:
|
Can we test some of the failure and edge cases as well. Things like:
We don't need to get too in-depth with it, that's what the unit tests are for, but testing some of the basic stuff would be a helpful sanity check. |
That's a good idea, will add all these cases. |
@lukebp Added all suggested test cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
This diff adds the RFP process to
piwww testrun
command.It covers the following commands:
And the following failures/edge cases as @lukebp suggested:
Closes #1190