[cms] Filter invoices by line item domain #1351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaur
reviewed
Jan 5, 2021
politeiawww/convert.go
Outdated
| var cmsDomain cms.AvailableDomain | ||
| for _, domain := range cms.PolicySupportedCMSDomains { | ||
| if int(domain.Type) == requestedDomain { | ||
| cmsDomain = domain |
There was a problem hiding this comment.
I guess PolicySupportedCMSDomains should never return two domains with the same type, but for extra safety this for loop might want a break.
alexlyp
force-pushed
the
ayp_domain_invoices
branch
from
129d1e6
to
2b069a0
Compare
alexlyp
added a commit
that referenced
this pull request
May 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1346
This changes the current way users are able to view others' invoices. Previously non-admin users were allowed to view all invoices submitted by others within their domain. Now users are able to see line items that match their domain. The rest of the line items that don't match domain and other private information are filtered out.