Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emails: Add record's token to email subjects. #1417

Merged
merged 2 commits into from May 22, 2021
Merged

Emails: Add record's token to email subjects. #1417

merged 2 commits into from May 22, 2021

Conversation

amass01
Copy link
Member

@amass01 amass01 commented May 20, 2021

Closes #1331.

lukebp
lukebp requested changes May 21, 2021
View reviewed changes
Copy link
Member

@lukebp lukebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing some emails. Go through all of these notifications and add where applicable.

image

@amass01
Copy link
Member Author

amass01 commented May 21, 2021

@lukebp Updated.

amass01
amass01 commented May 21, 2021
View reviewed changes
politeiawww/pi/mail.go Outdated Show resolved Hide resolved
lukebp
lukebp approved these changes May 22, 2021
View reviewed changes
Copy link
Member

@lukebp lukebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@lukebp lukebp merged commit 47ea630 into decred:master May 22, 2021
@amass01 amass01 deleted the uniqueemail branch May 22, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebp lukebp lukebp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

politeiawww: implement unique subject in emails
2 participants
@amass01 @lukebp