Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d/backendv2: Fix trillian rfc6962 import. #1433

Merged
merged 1 commit into from Jun 28, 2021
Merged

d/backendv2: Fix trillian rfc6962 import. #1433

merged 1 commit into from Jun 28, 2021

Conversation

lukebp
Copy link
Member

@lukebp lukebp commented Jun 21, 2021 •
edited

When the timestamp verify functions were moved out of the tstore package
it silently broke the politeiaverify tool. politeiaverify now
returns the following error when attempting to verify timestamps.

LogHasher(RFC6962_SHA256) is an unknown hasher

Importing the google/trillian/merkle/rfc6962 using a blank identifier
fixes this issue.

@lukebp
d/backendv2: Fix trillian rfc6962 import.
dc741b5 
When the timestamp verify functions were moved out of the tstore package
it silently broke the `politeiaverify` tool. `politeiaverify` now
returns the following error when attempting to verify timestamps.

`LogHasher(RFC6962_SHA256) is an unknown hasher`

Importing the `google/trillian/merkle/rfc6962` using a blank identifier
fixes this issue.

I really don't like this blank identifier design pattern that google
chooses to use. Things should not fail silently like this.
marcopeereboom
marcopeereboom approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@marcopeereboom marcopeereboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If i had $1 for every time this bit me...

@lukebp lukebp merged commit 40ca541 into decred:master Jun 28, 2021
@lukebp lukebp deleted the trillian-verify branch July 28, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcopeereboom marcopeereboom marcopeereboom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukebp @marcopeereboom