-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
comments: Update signature and settings. #1487
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add the plugin setting with plugin setting validation
amass01
changed the title
[wip] comments: Update signature and settings
comments: Update signature and settings
Aug 11, 2021
lukebp
requested changes
Aug 12, 2021
lukebp
reviewed
Aug 12, 2021
lukebp
approved these changes
Aug 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
marcopeereboom
suggested changes
Aug 16, 2021
@marcopeereboom updated |
marcopeereboom
approved these changes
Aug 16, 2021
lukebp
requested changes
Aug 17, 2021
lukebp
approved these changes
Aug 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
lukebp
changed the title
comments: Update signature and settings
comments: Update signature and settings.
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff adds
ExtraData
&ExtraDataHint
fields to theSignature
field in both
New
&Edit
comments plugin commands.Also, this updates the
Signature
validation and adds a newcomments plugin setting
allowExtraData
with a new validation to ensureno extra data is provided while the setting is switched off.
Closes #1483.