politeiad: Execute batch reads concurrently. #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the politeiad batch read route to execute the read commands concurrently instead of serially in order to improve performance. Each batch of read commands is executed using a sync WaitGroup counter to track the completion status of the commands and a shared memory cache to aggreate the replies. The memory cache is local to each read batch.
This commit updates the politeiad batch read route to execute the read commands concurrently instead of serially in order to improve performance. A batch of read commands is executed using a sync WaitGroup counter to track the completion status of the commands and a shared memory cache to aggregate the replies. Each batch uses its own unique memory cache. This performance optimization cut the execution of a 5 command read batch by ~50%.
lukebp
changed the title
|
@amass01 please test this when you get a chance. |
amass01
approved these changes
Dec 3, 2021
lukebp
added
91cfcc8
performance-impovement
pi-not-deployed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1582.
This commit updates the politeiad batch read route to execute the read
commands concurrently instead of serially in order to improve
performance.
A batch of read commands is executed using a sync WaitGroup counter to
track the completion status of the commands and a shared memory cache to
aggregate the replies. Each batch uses its own unique memory cache.
This performance optimization cut the execution time of a 5 command batch
by ~50%.