Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: Add routes page sizes as plugin settings. #1604

Merged
merged 5 commits into from Dec 28, 2021

Conversation

amass01
Copy link
Member

@amass01 amass01 commented Dec 15, 2021

Until this commit we have defined page sizes as global consts in our
plugins, this might result in some duplicated code if the page size is
needed in both politeiawww & politeiad.

This resolves the issue mentioned above by defining the plugins page
sizes as plugin setting, that way we have it available in both places
and easily configurable by sys admin without any code changes.


Closes #1603.

Untill this commit we have defined page sizes as global consts in our
plugins, this might result in some duplicated code if the page size is
needed in both `politeiawww` & `politeiad`.

This resolves the issue mentioned above by defining the plugins page
sizes as plugin setting, that way we have it available in both places
and easily configurable by sys admin without any code changes.
Copy link
Member

@lukebp lukebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Verified the politeiavoter pagination changes work as expected. I tested the inventory command with 3 ongoing proposal votes (single page) and 8 ongoing proposal votes (multi page).

@lukebp lukebp merged commit b846b94 into decred:master Dec 28, 2021
@amass01 amass01 deleted the pagesizessettings branch December 28, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multi: Add routes page sizes as plugin settings.
2 participants