Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi: Add routes page sizes as plugin settings. #1603

Closed
amass01 opened this issue Dec 12, 2021 · 0 comments · Fixed by #1604
Closed

multi: Add routes page sizes as plugin settings. #1603

amass01 opened this issue Dec 12, 2021 · 0 comments · Fixed by #1604
Assignees
@amass01

Comments

@amass01
Copy link
Member

amass01 commented Dec 12, 2021

Until now we have defined page sizes as global consts in our plugins, this caused some
duplicated code if the page size is needed in both politeiawww & politeiad.

In #1598 I solved that be defining the comment votes page size as plugin setting, that
way we have it available in both places and easily configurable by sys admin without
any code changes.

We would like to convert all existing global consts to plugin settings as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amass01 amass01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

multi: Add routes page sizes as plugin settings. amass01/politeia
1 participant
@amass01