[cms] Add Support, Oppose and Comment DCC functionality #981
Conversation
|
Why are separate routes needed for support and oppose? If they're normal comments, would it be simpler to just use the comment route and then have politeiawww check if they parse to "aye" or "nay"? |
|
Yah I had thought of that. Mostly I wanted these comments to be set apart and not a reply to another comment or anything (parent 0). And plus I was worried about the possibility of someone commenting multiple times with aye or nay. In its current form, comments don't allow aye or nay. Definitely possible to go in that direction if you'd like. Just would need to update validation a bit. |
You could make specific "aye" and "nay" buttons in the gui that format the comment correctly and send it. @marcopeereboom what do you think? Multiple routes or add additional validation to the comment route? |
|
I think this belongs in a stream with a single route. The GUI can have multiple buttons to send whatever to the stream journal. |
|
OK will make the suggested change to use just the NewComment route |
alexlyp
changed the title
I think he meant that this data belongs in a mdstream instead of a comment. So you would have a single route that allows the user to vote "aye" or "nay" on the DCC and this data would be saved in politeiad as an mdstream. Every time someone else votes on the DCC you append the vote onto the mdstream. I agree with this as well. In retrospect, it makes more sense to use an mdstream than to try and re-purpose a comment. |
This PR adds the ability for users to offer their support, opposition and comment on active DCC proposals (issuances or revocations). When a user offers there support or opposition of a given DCC proposal, metadata containing user information is appended on the existing journal entry on the politeiad backend. This is similar to the process of changing the status of a proposal. All changes are tracked and immutable once attached to a journal entry.
Requires #980
This PR adds the ability for users to offer their support, opposition
and comment on active DCC proposals (issuances or revocations).
When an authorized user submits a Support or Opposition request,
metadata from the request is appended to the existing DCC on
the politeiad backend. This makes them permanent and verifiable.