Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin propsoals list: tabs not workong properly. #2361

Closed
amass01 opened this issue Apr 30, 2021 · 3 comments · Fixed by #2406
Closed

Admin propsoals list: tabs not workong properly. #2361

amass01 opened this issue Apr 30, 2021 · 3 comments · Fixed by #2406
Assignees

Comments

@amass01
Copy link
Member

amass01 commented Apr 30, 2021

Currently switching tabs not adding a query param to the url, also can't use tab specific url to navigate directly
to the second or third tab.

@amass01
Copy link
Member Author

amass01 commented Apr 30, 2021

@lukebp i remember at some point we have changed the admin proposal list to have some new tabs: unreviewed, unvetted censored & vetted censored(archived?).
i see in the code now that this isn't the case anymore, we have joined the unvetted & vetted proposals back to one list,
what does archived mean in this case ? asking as it might be irrelevant, and we might need to revert back to only two tabs unreviewed & censored (this was the case before tlog iirc) ?
this should be part of the work to resolve this issue i think.

@amass01
Copy link
Member Author

amass01 commented Apr 30, 2021

Given @lukebp's answer on matrix:

public proposals are abandoned when the author becomes unresponsive. If a author did that for an unvetted proposal the admins would just censor it. Could we allow admins to mark unvetted proposals as abandoned? Sure, but when you censor a proposal it actually deletes the files so it keeps things cleaner if admins can only censored unvetted proposals. There's not much point in making the disctinction between censored/abandoned for unvetted proposals.

Archived tab is irrelevant and should be ditched.

@amass01
Copy link
Member Author

amass01 commented Apr 30, 2021

I will take care of this one and cleanup the admin list a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants