Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: Proposal author updates mock structure #2707

Closed
victorgcramos opened this issue Jan 10, 2022 · 1 comment · Fixed by #2733
Closed

e2e: Proposal author updates mock structure #2707

victorgcramos opened this issue Jan 10, 2022 · 1 comment · Fixed by #2733

Comments

@victorgcramos
Copy link
Member

Part of #2642.

Proposal author updates tests are still using the online api approach. We need to migrate it to the new mock structure introduced by (#2624).

We currently don't need new test suites, the main focus here is to first migrate and then code more tests using this new structure.

Tips and Tricks

  • Run only authorUpdates test file: yarn cy:run -- --spec "cypress/e2e/comments/authorUpdates.js"
  • Setup the API environment for all possible routes reached by the tests suite using a beforeEach statement
  • Check on politeiawww's logs to check if all requests were mocked properly
@victorgcramos victorgcramos mentioned this issue Jan 10, 2022
Closed
14 tasks
@vibros68
Copy link
Contributor

vibros68 commented Feb 5, 2022

I am on it

This was referenced Feb 22, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(e2e): Author Updates mock structure. victorgcramos/politeiagui
2 participants
@victorgcramos @vibros68