Update dark mode toggle switch #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebp
requested changes
Sep 16, 2021
|
@lukebp the current delay time for animation effect is 200 mili second. While the change of the variable is immediately. May be I should change the animation effect to 100, so the time seems to fit better. Or we can update the variable after the animation was done. So we will see the change of background after the button animation process |
|
What about taking out the delay entirely? It doesn't look like there is one on test-proposals. tmp-2021-09-17_07.24.42.mp4 |
lukebp
approved these changes
Sep 30, 2021
tiagoalvesdulce
approved these changes
Sep 30, 2021
| height: 100%; | ||
| display: flex; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .navContainer { | ||
| composes: sharedNavAtribute; |
There was a problem hiding this comment.
good job using composes!
|
Depended on decred/pi-ui#370. |
|
Posting here for future tweet.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2497
This pull request update the dark mode toggle to be a new designed
toggle. The preview of the toggle here:
It also does some adjustments with nav header style follow the comment
The preview behavior can be seen in the below video:
vokoscreen-2021-09-16_23-24-38.mp4