fix: Go Back link navigation #2658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: render comments for unvetted authors
lukebp
approved these changes
Nov 17, 2021
tiagoalvesdulce
approved these changes
Nov 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2655.
This diff fixes the Go Back link navigation by adding the
breakpointprop,where users can inform the route match path that should be considered a
navigation rollback point.
Fortunately, due to privacy matters, the browsers don't allow the previous
history states access. Therefore, the method used consists in storing the
previous navigated pages on our platform in a stack, and then getting the
index of the first route that does not match the current breakpoint. This way
we can restore the window navigation state, instead of pushing a new one.