fix: Infinite loading on admin approved list #2674
Conversation
There was a problem hiding this comment.
-
Don't add a separate loading animation for the button. Having multiple loading animations all over the place is distracting and bad UX. The main loading animation should be displayed until all of the data has been retrieved to display the list.
-
This is caught in an infinte loop on refresh, so something is off anyway.
Fixes the admin billing changes infinite loading after login with a previously loaded approved proposals list.
I wasn't able to reproduce this on master. What are the reproduction steps?
tmp-2021-11-24_10.44.35.mp4
|
The infinite loop is actually a loop that fetches all existing approved proposals. I wasn't able to reproduce it initially becuase I only had a single page of approved proposals in my test env. |
|
Reproduction steps for button infinite loading on firefox:
|
There was a problem hiding this comment.
@victorgcramos I'm not seeing the infinite loading anymore, but the billing status buttons still disappear on refresh. The infinite loading was caused by the billing statuses not being fetched. Looks like this is the same root cause.
tmp-2021-11-29_13.59.58.mp4
|
@lukebp this is how it looks like now. Thanks for the review and the helpful thoughts.
|
| const needsBillingStatus = | ||
| !isLegacy && !isRfp && isApproved && currentUser?.isadmin; | ||
| const isSetBillingStatusAllowed = | ||
| !isLegacy && | ||
| !isRfp && | ||
| isApproved && | ||
| numbillingstatuschanges < billingstatuschangesmax; | ||
| needsBillingStatus && numbillingstatuschanges < billingstatuschangesmax; |
tiagoalvesdulce
added
the
pi-not-deployed
Closes #2672.
Fixes the admin billing changes infinite loading after login with a
previously loaded approved proposals list.
Adds loading indicator for billing status changes
Ui Changes