e2e: Proposal Create mock structure. #2676

vibros68 · 2021-11-27T04:32:39Z

This diff create mock data for record/new endpoint. So when creating
proposal e2e test is running. The test will not send the request to the
server. And complete the e2e test for creating normal proposal. Include
select domain and pickup datepickers

vibros68 · 2021-11-28T04:38:55Z

@victorgcramos can you review this pr?

victorgcramos

records/v1/new endpoint mock looks good, mate. Thanks! Left some inline comments.

Good to remind that mocking the records/new endpoint does not close the full issue, as It expected the whole proposal/create flow to be mocked so we don't need to be connected to the backend.

victorgcramos · 2021-11-29T18:45:22Z

teste2e/cypress/support/core/api.js

+export function newRecordSummaryReply({ requestParams: { tokens = [] } }) {
+  const summaries = tokens.reduce((sum, token) => {
+    sum[token] = { status: "unvetted" };
+    return sum;
+  }, {});
+  return { summaries };
+}


records summaries does not exist. Could you remove it, please?

victorgcramos · 2021-11-29T19:04:14Z

teste2e/cypress/e2e/proposal/create.js

+import {
+  PROPOSAL_SUMMARY_STATUS_ACTIVE,
+  PROPOSAL_SUMMARY_STATUS_UNVETTED
+} from "../../utils";


Unused variables

victorgcramos · 2021-11-29T21:50:56Z

src/components/ProposalForm/ProposalForm.jsx

@@ -336,6 +339,8 @@ const ProposalForm = React.memo(function ProposalForm({
      )}
      <SelectField
        name="domain"
+        id="domain-selector"
+        dataTestid="domain-selector"


is this used elsewhere?

This commit adds the `verifyIdentity` option to user login and me requests, and improves the proposal create tests to avoid reaching any backend endpoints.

Improvements for Proposal Create mock

…est case

victorgcramos

Looking better now. Tests are working as expected, and thanks for adding an extra test case.

I have some small observations regarding the test cases descriptions: they should start with "should". Left one inline suggestion regarding it, which you should replicate for all test cases you create.

Left some other inline suggestions 😁

victorgcramos · 2021-11-30T17:18:47Z

teste2e/cypress/e2e/proposal/create.js

+    cy.findByRole("button", { name: /submit/i }).click();
+    // needs more time in general to complete this request so we increase the
+    // responseTimeout
+    cy.wait("@newProposal", { timeout: 10000 }).should((xhr) => {


try using cy.wait("@records.new") instead, and see if you can decrease this timeout. 10s timeout is too much.

victorgcramos · 2021-11-30T17:21:14Z

src/components/ProposalForm/ProposalForm.jsx

@@ -336,6 +337,7 @@ const ProposalForm = React.memo(function ProposalForm({
      )}
      <SelectField
        name="domain"
+        id="domain-selector"


Suggested change

id="domain-selector"

id="proposal-domain-selector"

victorgcramos · 2021-11-30T18:24:31Z

teste2e/cypress/support/commands.js

@@ -149,22 +158,24 @@ Cypress.Commands.add("approveProposal", ({ token }) =>
 Cypress.Commands.add("typeCreateProposal", (proposal) => {
  cy.server();
  cy.findByTestId("proposal-name").type(proposal.name);
-  cy.findByTestId("text-area").type(proposal.description);
+  cy.findByTestId("proposal-amount").type(String(proposal.amount / 100)); // get dollars from cents.


Prettier: 80 max char per line.

victorgcramos · 2021-11-30T18:43:06Z

teste2e/cypress/support/core/api.js

@@ -101,7 +101,32 @@ export function detailsReply({
  return { record };
 }

+/**
+ * newRecordReply is the reply to the new command. It returns a new record for the
+ * request data with given `files`, `publickey`, `signature` and `author` testParams.


The parameters from this replier doc is different from the replier's parameters.

victorgcramos · 2021-11-30T18:44:04Z

teste2e/cypress/support/core/api.js

@@ -1,4 +1,4 @@
-import { Record, File, Inventory } from "./generate";
+import { Record, File, Inventory, Proposal } from "./generate";


Proposal is never used and does not exist on generate scope.

victorgcramos · 2021-11-30T18:54:43Z

teste2e/cypress/e2e/proposal/create.js

 describe("Proposal Create", () => {
  // XXX This test needs changes in the Datepicker and (probably) the Select
  // components, in order to fill the new form fields such as: start & end dates
  // and amount - issue to track <insert issue link>
  //
-  /*it("Paid user can create proposals manually", () => {
+  it("Paid user can create proposals manually", () => {


Suggested change

it("Paid user can create proposals manually", () => {

it("should be able to create proposals", () => {

victorgcramos

I'm getting an error on your test run. Please fix it :D

teste2e/cypress/support/commands.js

victorgcramos

Looking really good. Left just one minor inline comment, and we should be good to go! Nice job @vibros68

victorgcramos · 2021-12-03T19:55:21Z

teste2e/cypress/support/core/generate.js

-      publickey: user.publickey,
-      signature,
+      publickey: publickey || user.publickey,
+      recordSignature,


Noticed some issues here. RecordMetadata has no recordSignature field. Actually, it's signature. Also, the signature should have a default value.

amass01 · 2021-12-04T12:32:34Z

teste2e/cypress/e2e/proposal/create.js

@@ -15,7 +15,7 @@ describe("Proposal Create", () => {
  // components, in order to fill the new form fields such as: start & end dates
  // and amount - issue to track <insert issue link>
  //
-  it("Paid user can create proposals manually", () => {
+  it("should be able to create proposals", () => {


Suggested change

it("should be able to create proposals", () => {

it("should allow paid user to create proposals", () => {

victorgcramos

tACK!

tiagoalvesdulce

LGTM

vibros68 added 4 commits November 27, 2021 11:31

Paid user can create proposals manually

5b97a79

make the test simpler

f895c71

fix linter

f8f57f4

remove dataTestid

099b142

vibros68 changed the title ~~[WIP] e2e: Proposal Create mock structure.~~ e2e: Proposal Create mock structure. Nov 28, 2021

get rid of Proposal mock and use Record

e0a0f84

victorgcramos requested changes Nov 29, 2021

View reviewed changes

victorgcramos and others added 5 commits November 29, 2021 19:18

e2e: improvements for proposal create mock

fba7bb4

This commit adds the `verifyIdentity` option to user login and me requests, and improves the proposal create tests to avoid reaching any backend endpoints.

Merge pull request #1 from victorgcramos/2676-improve

1d71b8e

Improvements for Proposal Create mock

add test case without fill the input; reuse type proposal on unpaid t…

706e6b9

…est case

prettify

abbb3c3

decorate code

7fc66ce

victorgcramos requested changes Nov 30, 2021

View reviewed changes

vibros68 added 2 commits December 2, 2021 19:17

fix follow review

bb479dd

adjust the test title

f888462

vibros68 requested a review from victorgcramos December 2, 2021 14:28

victorgcramos requested changes Dec 2, 2021

View reviewed changes

teste2e/cypress/support/commands.js Outdated Show resolved Hide resolved

teste2e/cypress/support/commands.js Outdated Show resolved Hide resolved

vibros68 added 4 commits December 2, 2021 22:22

fix proposal-domain-selector wrong name

df69ed7

remove unused variable and fix 80 chars per line

46df268

prettify

c5919b3

remove unused var and comments

e56ed4e

victorgcramos requested changes Dec 3, 2021

View reviewed changes

fix Record signature

3a5dab9

amass01 reviewed Dec 4, 2021

View reviewed changes

fix test title

384b63a

victorgcramos approved these changes Dec 6, 2021

View reviewed changes

tiagoalvesdulce approved these changes Dec 7, 2021

View reviewed changes

tiagoalvesdulce merged commit 19e2970 into decred:master Dec 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

e2e: Proposal Create mock structure. #2676

e2e: Proposal Create mock structure. #2676

vibros68 commented Nov 27, 2021 •

edited

vibros68 commented Nov 28, 2021

victorgcramos left a comment

victorgcramos Nov 29, 2021

victorgcramos Nov 29, 2021

victorgcramos Nov 29, 2021

victorgcramos left a comment

victorgcramos Nov 30, 2021 •

edited

victorgcramos Nov 30, 2021

victorgcramos Nov 30, 2021

victorgcramos Nov 30, 2021

victorgcramos Nov 30, 2021

victorgcramos Nov 30, 2021

victorgcramos left a comment

victorgcramos left a comment

victorgcramos Dec 3, 2021

amass01 Dec 4, 2021

victorgcramos left a comment

tiagoalvesdulce left a comment

		@@ -1,4 +1,4 @@
		import { Record, File, Inventory } from "./generate";
		import { Record, File, Inventory, Proposal } from "./generate";

	it("Paid user can create proposals manually", () => {
	it("should be able to create proposals", () => {

	it("should be able to create proposals", () => {
	it("should allow paid user to create proposals", () => {

e2e: Proposal Create mock structure. #2676

e2e: Proposal Create mock structure. #2676

Conversation

vibros68 commented Nov 27, 2021 • edited

vibros68 commented Nov 28, 2021

victorgcramos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

victorgcramos left a comment

Choose a reason for hiding this comment

victorgcramos Nov 30, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

victorgcramos left a comment

Choose a reason for hiding this comment

victorgcramos left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

victorgcramos left a comment

Choose a reason for hiding this comment

tiagoalvesdulce left a comment

Choose a reason for hiding this comment

vibros68 commented Nov 27, 2021 •

edited

victorgcramos Nov 30, 2021 •

edited