Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: User menu alignment on mobile. #2682

Merged

Conversation

victorgcramos
Copy link
Member

Closes #2681

UI Changes Screenshot

Before:
Screen Shot 2021-11-30 at 4 24 22 PM

After:
Screen Shot 2021-11-30 at 4 19 51 PM

@victorgcramos victorgcramos changed the title fix: user menu alignment fix: User menu alignment. Nov 30, 2021
@victorgcramos victorgcramos changed the title fix: User menu alignment. fix: User menu alignment on mobile. Nov 30, 2021
Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this fixes the menu for mobile, it breaks it for other screen sizes. See:

Screen Shot 2021-12-01 at 10 19 23

@victorgcramos
Copy link
Member Author

@tiagoalvesdulce thanks! This is also reproducible on test-proposals. Will push a fix.

@victorgcramos
Copy link
Member Author

2681-mobile-screen

@tiagoalvesdulce tiagoalvesdulce merged commit c557641 into decred:master Dec 2, 2021
@tiagoalvesdulce tiagoalvesdulce added the pi-not-deployed This item has been merged into master, but has not been deployed to production yet. label Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pi-not-deployed This item has been merged into master, but has not been deployed to production yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User menu misalignment on mobile
2 participants