Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: Add Proposal New page #2751

Merged
merged 34 commits into from Jun 13, 2022

Conversation

victorgcramos
Copy link
Member

@victorgcramos victorgcramos commented Apr 19, 2022

Closes #2759
Closes #2740

This PR implements the Proposal New page, using the also implemented
RecordForm structure.

⚠️ Depends on:

Pi

Common-ui

Preview

Screen Shot 2022-04-19 at 7 14 49 PM

@victorgcramos
Copy link
Member Author

Preview:

Screen Shot 2022-05-03 at 11 30 51 AM

@victorgcramos
Copy link
Member Author

Before / After

Regular Proposal

Screen Shot 2022-05-03 at 6 46 13 PM Screen Shot 2022-05-03 at 6 46 01 PM

RFP Proposal

Screen Shot 2022-05-03 at 6 48 44 PM Screen Shot 2022-05-03 at 6 48 31 PM

RFP Submission

Screen Shot 2022-05-03 at 6 50 43 PM Screen Shot 2022-05-03 at 6 50 35 PM

@victorgcramos victorgcramos changed the title [WIP] multi: Add Proposal New page multi: Add Proposal New page May 3, 2022
@victorgcramos victorgcramos marked this pull request as ready for review May 3, 2022 22:01
Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. I like the improved design. A few comments:

  1. The info tooltips for the RFP Tokens and RFP Deadlines are missing.
  2. Tab navigation can be improved. Ideally we should be able to navigate through the page with the Keyboard (https://webaim.org/techniques/keyboard/). This should probably be done in the Form components.
  3. Margin between the markdown editor and Domain select can be increased a little to match the other inputs:

Screen Shot 2022-05-04 at 14 07 05

@victorgcramos
Copy link
Member Author

@tiagoalvesdulce thanks for the feedback!

  1. Opened an issue on pi-ui so we can add those icons inside the input: [BoxTextInput] Add Info icon tooltip pi-ui#444
  2. Datepicker currently has no arrow navigation implemented. Opened an issue on pi-ui: [Datepicker] Make datepicker arrow responsive pi-ui#445. Improved tabs navigation on the other inputs.
  3. Done!

@victorgcramos
Copy link
Member Author

Accessible navigation preview

datepicker-arrow-v2.mp4

Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keyboard navigation is looking pretty good.

One small thing: after writing the proposal description you should focus on the Save Draft and Submit buttons in the bottom when hitting tab.

Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiagoalvesdulce tiagoalvesdulce merged commit a2357fa into decred:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants