Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

legacy: Fix Proposal Dates. #2771

Merged
merged 6 commits into from May 26, 2022

Conversation

victorgcramos
Copy link
Member

Closes #2770

⚠️ Depends on decred/pi-ui#451 ⚠️

This PR fixes proposal dates errors and adds an formatter for error
contexts that have timestamps.

  • Uses DatePickerV2 for proposal dates
  • Format error timestamps to a human friendly message
    Screen Shot 2022-05-24 at 7 52 53 PM
  • Fix proposal ranges based on policy values

Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rephrase the error msg to something like:

Proposal end date is invalid. Date should be between <START> and <END>. Got: <DATE>

src/components/ProposalForm/ProposalForm.jsx Outdated Show resolved Hide resolved
src/helpers.js Outdated Show resolved Hide resolved
src/utils.js Show resolved Hide resolved
Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@tiagoalvesdulce tiagoalvesdulce merged commit 51f2140 into decred:master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal date bugs.
2 participants