Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(politeiagui-scripts): add jest/babel configuration #2838

Merged
merged 2 commits into from Aug 4, 2022

Conversation

tiagoalvesdulce
Copy link
Member

@tiagoalvesdulce tiagoalvesdulce commented Aug 3, 2022

This PR adds babel configuration for jest test env to politeiagui-scripts. This way, babel.config and jest.config are no longer needed on plugins. If the plugin has a babel.config or jest.config the default configs will be ignored and the plugin file will be the one used by politeiagui-scripts.

Copy link
Member

@victorgcramos victorgcramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if I'm doing the correct setup, but when I run the politeiagui-scripts test command on packages/core path, I get the following error:

SyntaxError: Cannot use import statement outside a module

In order to avoid that, I think it would be nice if you added some examples for that command on politeiagui-scripts readme. What do you think?

plugins-structure/packages/cli/package.json Show resolved Hide resolved
@tiagoalvesdulce
Copy link
Member Author

tiagoalvesdulce commented Aug 4, 2022

I'm not sure if I'm doing the correct setup, but when I run the politeiagui-scripts test command on packages/core path, I get the following error

Yeah, you have to run a fresh yarn install inside politeiagui-scripts.

In order to avoid that, I think it would be nice if you added some examples for that command on politeiagui-scripts readme. What do you think?

I don't think we need that since it's just a package that moved from the plugins/apps to the politeiagui-scripts package

@victorgcramos
Copy link
Member

@tiagoalvesdulce after a fresh install, it works as expected. Thanks!

Copy link
Member

@victorgcramos victorgcramos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@victorgcramos victorgcramos merged commit 1daeff6 into decred:master Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants