fix(multi): core API error fixes + E2E tests fixes #2872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some errors on politeia app e2e tests. While fixing those
errors, I noticed that some API errors were being handled incorrectly,
due to an incorrect variable usage, which were causing tests to fail.
Before:
After:
I also added some e2e tests for app startup errors, which asserts that
/apierrors are displayed correctly. Once server returns an error, weshould also display the error codes. However, if no response body is
returned, we should display the generic
Cannot fetch "${url}". Is politeiawww running?message.