Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: User Proposals page layout #2877

Merged
merged 25 commits into from Nov 30, 2022

Conversation

victorgcramos
Copy link
Member

@victorgcramos victorgcramos commented Nov 15, 2022

This PR adds the initial view for User Details page, and implements
a preview version of user proposals, but using records inventory
instead, while user layer isn't implemented on backend.

One thing worth to mention is that this PR refactors our Home page
records list components to a more reusable approach, not exclusively
dedicated to Home methods.

Proposals List are now a separate component that uses pi plugin actions
and selectors. With this approach, we will be able to reuse the list
on User Proposals, Admin proposals and other stuff.

Screen Shot 2022-11-21 at 11 42 24 AM

Changelog

  • Add User Details page layout
  • Add User submitted proposals page scope (with records inventory)
  • Decouple Proposals List components
  • Improve RecordsList component
  • Add E2E tests for User Proposals page
  • Add Components tests for ProposalsList + improve RecordsList tests
  • Cleanup Home page components
  • Isolate ProposalsList services
  • Add hooks for inventory and proposals

@victorgcramos victorgcramos marked this pull request as ready for review November 21, 2022 14:43
Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@tiagoalvesdulce tiagoalvesdulce merged commit 72634b5 into decred:master Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants