New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: User Proposals page layout #2877
Merged
tiagoalvesdulce
merged 25 commits into
decred:master
from
victorgcramos:pi/user-proposals
Nov 30, 2022
Merged
feat: User Proposals page layout #2877
tiagoalvesdulce
merged 25 commits into
decred:master
from
victorgcramos:pi/user-proposals
Nov 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move proposal list components from pages/Home/common to components; - link list actions to pi proposal actions, not home actions - Home page listeners now using pi proposal actions - Fix e2e tests - add hooks for proposals list and vote inventory
- pi: add ProposalsList component and hooks - common-ui: records list + infinite scroller refactor
tiagoalvesdulce
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the initial view for User Details page, and implements
a preview version of user proposals, but using records inventory
instead, while user layer isn't implemented on backend.
One thing worth to mention is that this PR refactors our Home page
records list components to a more reusable approach, not exclusively
dedicated to Home methods.
Proposals List are now a separate component that uses pi plugin actions
and selectors. With this approach, we will be able to reuse the list
on User Proposals, Admin proposals and other stuff.
Changelog