Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build flavor support, and build dexc with tray flavor #90

Merged
merged 2 commits into from Apr 20, 2023

Conversation

jrick
Copy link
Member

@jrick jrick commented Apr 19, 2023

Add flavor support

Optional flavors may be added to a build target, resulting in
additional flavored executables being built and packaged. A flavor
may be built for all operating systems, or limited to a particular
one. The flavorbuild function returns a modified tags and ldflags
that the flavor is built with.

Add dexc tray flavor

When built for Windows, dexc is built with the -H=windowsgui linker
flag and systray build tag, resulting in a Windows GUI application
(that lives in the taskbar) rather than a console executable.

Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. -tags systray is another component of flavor, at least for the tray flavor.

Optional flavors may be added to a build target, resulting in
additional flavored executables being built and packaged.  A flavor
may be built for all operating systems, or limited to a particular
one.  The flavorbuild function returns a modified tags and ldflags
that the flavor is built with.
@jrick jrick force-pushed the dexc-tray branch 3 times, most recently from 8fa3000 to 05e5f30 Compare April 19, 2023 18:49
When built for Windows, dexc is built with the -H=windowsgui linker
flag and systray build tag, resulting in a Windows GUI application
(that lives in the taskbar) rather than a console executable.
Copy link
Member

@chappjc chappjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dist/dexc-v0.6.0/dexc-windows-amd64-v0.6.0 exe files look good. Tested both flavors in Win7.

The tags approach seems to assume some default tags first, which there are presently for all archs, otherwise -tags=,systray, which actually might be fine anyway.

@jrick jrick merged commit 886e603 into decred:master Apr 20, 2023
2 checks passed
@jrick jrick deleted the dexc-tray branch April 20, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants