Set and display ticket purchase height #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only show purchase height when the ticket is confirmed, because if a ticket is not confirmed, its purchase height is not yet known.
dajohi
approved these changes
May 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had an ulterior motive when splitting this work out from #245. I suspected that purchase height was not being set correctly in all cases, and I was correct. It was only being set for tickets which were not already mature when added to the VSP, and it was never set for already mature ticket. The first commit in this PR fixes that bug.
The second commit displays the purchase height in the admin page with a link to the block explorer. Purchase height is only shown when the ticket is confirmed because if a ticket is not confirmed, its purchase height is not yet known.