Enable long running processes to be interrupted #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
reviewed
Sep 7, 2023
Using a single select loop for background tasks removes a lot of duplicated boilerplate code and helps to simplify shutdown logic. This does reduce the amount of things which can run in parallel, but that isn't of concern for vspd. The web server still runs in its own goroutine so its responsiveness won't be affected.
The more verbose name was helpful in the past when some code was handling more than one context, however that is no longer the case due to refactoring so reverting to the more concise name makes sense.
vspd runs some tasks on startup - database consistency checks, catching up with missed blocks, etc. If a shutdown is requested while these tasks are running, vspd should stop immediately rather than continuing to start the web API server and other background tasks.
Add a Context parameter to findSpentTickets so it can be canceled when a shutdown is requested.
Check the status of the Context in blockConnected so it can be canceled when a shutdown is requested.
Add a Context parameter to checkWalletConsistency so it can be canceled when a shutdown is requested.
davecgh
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds shutdown request handling for startup processes and long-running background tasks.
Requires #424