Move vspd to an internal package. #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
reviewed
Sep 16, 2023
Creating the essential DB/RPC resources which are required for both webapi and vspd in the main func allows the two components to be decoupled.
The vspd Run func is now blocking and returns when its provided context is cancelled. This means it is invoked/canceled in the same way as the webapi Run func. webapi is now created in the main run func rather than within vspd, further decoupling these components.
jholdstock
force-pushed
the
internal-again2
branch
from
5b07d3c
to
c3a9697
Compare
Don't log errors returned by server.Shutdown. They are exceedingly unlikely, and there is nothing which can be done about them. Moving the "Listening on..." log closer to where the server is actually started reduces the chance of confusion. Also, logging the parsed listener.Addr() string instead of the provided config string provides extra debugging detail.
jholdstock
force-pushed
the
internal-again2
branch
from
c3a9697
to
7c590c9
Compare
davecgh
approved these changes
Sep 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #434
This series of commits culminates in the vspd code being moved to an internal package. Along the way it decouples the webapi package from vspd code, and moves both the webapi and vspd components to a new pattern for starting/stopping subsystems, namely:
This is desirable because it is concise and easy to understand. Adding to and removing from waitgroups all in one place is a good practise to be following.