-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bonzo produces duplicate named modules when compiled with r.js #98
Comments
I'd be happy to remove the |
@rvagg great, that would be very helpful. |
hey @commuterjoy (and @rvagg ) according to amd's define(['someModule'] , function (myMod) {
return function () {};
}); it even says so on the RequireJS website on why amd so what i don't get is, how this works with bean (which is doing it wrong), and not bonzo, qwery, and reqwest. |
ok, really trying to get this right. have a look at this too: http://requirejs.org/docs/api.html#defdep from what it looks like, the define method can have a first arg which is an array of dependencies. and in that case, bonzo has no dependencies...... which means we can switch it out to look like bean. |
alright folks. this has been fixed and i verified it to be working i added cheers |
Hi,
Bonzo (and Reqwest + Qwery) all produce an empty named AMD module when used with r.js
They all produces this after compilation, alongside the original module :-
Test case, https://github.com/guardian/requirejs-optimiser-bug
requirejs (client-side) conveniently ignores this, but curl and almond throw exceptions due to duplicate module names.
So, I think r.js is misinterpreting this line for some reason,
Various other modules (Eg, bean etc.) don't have this problem.
I'm using the latest r.js package,
Thanks,
M
The text was updated successfully, but these errors were encountered: