Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you be interested in some PR's? #8

Open
roni-estein opened this issue Apr 14, 2021 · 2 comments
Open

Would you be interested in some PR's? #8

roni-estein opened this issue Apr 14, 2021 · 2 comments

Comments

@roni-estein
Copy link
Contributor

Hey I'm working on a project that needs to convert a forum from BBcode to Markdown, there are some items not handled here. I know this project is quite old. Would you be interested in PR's or would you prefer if I just fix it on my for and leave it alone?

Thanks for the code and have a super day!

@dedalozzo
Copy link
Owner

Sure, feel free to extend and add the necessary support for what is not handled. I wrote this library because nothing was available, but I didn't converted everything, just what I was actually using. Waiting for your pull requests. It would be great to add some tests as well, since I didn't.

@roni-estein
Copy link
Contributor Author

Thanks, I didn't have a change to write any tests, just pulled it together in tinkerwell, but I was moving items over from xferno forums to a custom laravel solution and they have some odd stuff that I'm running across like "[left]" and [color=blue] or [color=#000000]. I'll start a PR with those, I may find some other items, I can add another some possible tests. I'm mostly a laravel developer so I use orchestra testbench to handle that side, I haven't really structured a "pure" php package version. If you know what you are looking for and put in a sample I'd be happy to use your conventions.

Also feel free to change/modify anything you feel like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants