-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Measurements #29
Comments
OK, so I found syscall.Getrusage which can give the usage-stats of the currently running process. Using that we could re-write the measurements:
But perhaps the wall-clock-time is also interesting. And the total time from |
Wait, I thought you were already using getrusage. What numbers is the CPU graph you sent me based on, if not that? |
The CPU-graph is using the ProcessState.SystemTime() on a command. I just discovered Getrusage today… The time/round is using wall clock. Le 8 oct. 2015 à 18:39, Bryan Ford notifications@github.com a écrit :
|
and ProcessState.UserTime() for user-time, right? Those should be fine too; they should measure the right thing anyway. But I guess you meant that the benefit of Getrusage is that you get the CPU time consumed by the calling process, not just by child processes? I guess I just misunderstood the concern. |
My main concern is to know what is important to measure. We have
So, when do we want to know what? In addition, consider:
|
Note to self: syscall.Getrusage doesn't measure anything for syscall.RUSAGE_CHILDREN |
Please comment on things we want to measure:
where processor-clock is given by |
For the set of graphs measuring round time, we want wall-clock time - the total amount of real time it takes to do a round, typically as perceived by the leader. For the set of graphs measuring CPU time, we want processor-clock time - i.e., the amount of processor time any or all CPUs have spent actually crunching on crypto and such, including parallel computing time, but not including time processors are waiting for network messages and such. Is that what you were asking? |
Yep, I was not completely sure whether we still need the wall-clock, but for the round-trip time it makes sense.
|
Continues in pull-request #42 |
Perhaps we should use better measurements than wall-clocking what is happening for each round. What are the possibilities to measure directly in the go-program how much cpu-power we used?
The text was updated successfully, but these errors were encountered: