Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default-port for proxy redirection #65

Closed
ineiti opened this issue Nov 11, 2015 · 8 comments
Closed

Default-port for proxy redirection #65

ineiti opened this issue Nov 11, 2015 · 8 comments

Comments

@ineiti
Copy link
Member

ineiti commented Nov 11, 2015

The default port should be 10001 instead of 4001, so that it doesn't interfere with the app-ports.

@nikkolasg
Copy link
Contributor

Actually It does not interfer since it is only on users.deterlab and not used to listen but to connect to the SSH tunnel. But you are right it is better to keep them close with the monitor port.

@ineiti
Copy link
Member Author

ineiti commented Nov 11, 2015

And when we run it locally? Doesn't it interfere then?

@nikkolasg
Copy link
Contributor

No proxy on local host.

@ineiti
Copy link
Member Author

ineiti commented Nov 11, 2015

OK - where is the main-proxy-port? Let's just put it 1 above the main-proxy-port per default.

@nikkolasg
Copy link
Contributor

What do you call the "main-proxy-port" ?
Proxy is listening on the same port as the main sink / monitor process, so users of the lib do not have to know if they connect to a proxy or directly the main sink. The port of the main sink is still static (that will change soon with after merging the quickfix_args branch, we will then put it in platform_config.toml) and is 10000.
The port the proxy connects to the sink (or the ssh tunnel) is written in deter.toml.

@ineiti
Copy link
Member Author

ineiti commented Nov 11, 2015

main-proxy-port -> sink-port -> 10000, so let's put the proxy at 10001. Then the sink and the proxy, which are similar in usage, are also similar in port-numbers.

@nikkolasg
Copy link
Contributor

You can already do that by changing your deter.toml, it is configurable. Only the sink port is not for now.

@nikkolasg
Copy link
Contributor

Note: careful, because we can not use the same port on users. ( just saw that you were experimenting too, and ssh was failing short ><) I moved mine to 10002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants