Tree phase comments #124
Closed
Tree phase comments #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // The public-key | ||
| PubKey abstract.Point | ||
| // The private-key - mostly for ourselves | ||
| PrivKey abstract.Secret |
There was a problem hiding this comment.
I don't think this should be in the Peer struct, given that it seems like it's definitely only for ourselves and should probably be "known" by ourselves in some other way.
There was a problem hiding this comment.
That's true. I just thought that it's the most convenient place to put it by putting similar things together. Else I'll have to put the private key somewhere in the Node structure (which doesn't exist yet)
Closed
| // The hash-id of this list | ||
| Hash hashid.HashId | ||
| // The suite used in this list | ||
| Suite abstract.Suite |
There was a problem hiding this comment.
Following our discussion, I think suite should not be here. Should it not be higher up, in the definition of what application we want to run(stamp,bitcosi etc) ?
|
Will start new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open for first comments of the new tree/peer structures.