Add a caching system for the stateTries … #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current stateTries have two bottlenecks: - LoadConfigFromTrie - which is called everytime a LoadDarcFromTrie is called and decodes the config protobuf structure every time anew - LoadDarcFromTrie - which is called when evaluating signatures or authorizations This PR adds a cache for both of these methods, so that calls within the same block are cached. The test, which is a bit artificial, gives the following improvements: - LoadConfigFromTrie - 3x faster authorization check - LoadDarcFromTrie - 4x faster authorization check The latter is a bit artificial, because it measures looking up the same darcs repeatedly, which in practice happens rarely. The first test, however, is very relevant. In the 9cc3-chain, it is even worse, as the config contains more nodes, which will make protobuf.Decode even slower.
tharvik
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current stateTries have two bottlenecks:
decodes the config protobuf structure every time anew
This PR adds a cache for both of these methods, so that calls within the
same block are cached. The test, which is a bit artificial, gives the
following improvements:
The latter is a bit artificial, because it measures looking up the same darcs
repeatedly, which in practice happens rarely.
The first test, however, is very relevant. In the 9cc3-chain, it is even worse,
as the config contains more nodes, which will make protobuf.Decode even
slower.
Closes #2258