Adding SkipchainDB.GetProofFromIndex #2423
Conversation
ineiti
force-pushed
the
get_full_proof
branch
from
9e1c4c8
to
ec337c7
Compare
skipchain/struct.go
Outdated
| }) | ||
| // GetProof returns the shortest chain from the genesis to the latest block | ||
| // using the highest forward-links available in the local db | ||
| func (db *SkipBlockDB) GetProof(sid SkipBlockID) (sbs []*SkipBlock, |
There was a problem hiding this comment.
As it is pretty much the same as GetFullProof, maybe it can be removed?
There was a problem hiding this comment.
I'm hesitating - it is public, so theoretically it could be used elsewhere, and I didn't want to break it. But looking at the usage, it's only in the skipchain package, so it should be fine. I can mark it Deprecated (even though we never really removed anything, did we?)
There was a problem hiding this comment.
I'm hesitating - it is public, so theoretically it could be used elsewhere, and I didn't want to break it. But looking at the usage, it's only in the
skipchainpackage, so it should be fine.
As you wish, I'm always in favor of reducing the number of exposed function, especially if it serves the same purpose.
I can mark it
Deprecated(even though we never really removed anything, did we?)
Yeah, to be nice with semver, we should do a new major release where we remove the deprecated functions, but that might never happen.
There was a problem hiding this comment.
Renamed the methods to make more sense:
- GetProofFromIndex - takes a skipchain-ID and an index
- GetProof - for compatibility, deprecated, not used anymore in the code
- GetProofForLatest - calls
GetProofFromIndexwith magical value-1- replaces previousGetProof
And the return values of all these methods is now the same. The Proof structure got a GetForwardLinks method.
|
And there is a Code Smell for the naming convention of test case. btw, I finally found my "golang standard" argument, in effective go. |
|
OK, bikeshedding for
So my take here is: follow the sheeps. dedis/cothority has |
Okay, then let's keep it as is, but you'll need to fix SonarCloud to avoid the next code smells :P |
|
Agreed, whatever the accepted rules are, the tools should be adjusted accordingly to remove false positives. :) |
|
Opened #2425 so we can go forward with this. |
ineiti
force-pushed
the
get_full_proof
branch
from
ec337c7
to
bc56a59
Compare
Previously the GetByID was only available as a service-endpoint, but as it is a handy method in general, this PR moves it to the SkipchainDB as `GetFullProof`, which can do much more. Also contains a fix to SkipBlock.pathForIndex
ineiti
force-pushed
the
get_full_proof
branch
from
bc56a59
to
87a2411
Compare
- GetFullProof -> GetProofFromIndex - GetProof -> GetProofFromLatest - GetProof: Deprecated Also changed the return-values from the GetProofs to always return a Proof. Added GetForwardLinks to the Proof structure. Added tests
|
OK - changed the names and signatures of the |
|
Kudos, SonarCloud Quality Gate passed!
|
ineiti
changed the title
Previously the GetByID was only available as a service-endpoint, but as it is
a handy method in general, this PR moves it to the SkipchainDB as
GetFullProof,which can do much more.
Also contains a fix to SkipBlock.pathForIndex