smaller set of changes #608
Conversation
|
adding test for copy so that coverall is happy... |
| @@ -288,3 +289,27 @@ func InputYN(def bool, args ...interface{}) bool { | |||
| } | |||
| return strings.ToLower(string(Input(defStr, args...)[0])) == "y" | |||
| } | |||
|
|
|||
| // Copy makes a copy of a local file with the same file-mode-bits set. | |||
| func Copy(dst, src string) error { | |||
There was a problem hiding this comment.
Is there is not another place where you put it in one of the PRs coming from the nsdi code ? Just asking if this is implemented twice or not, because I saw this piece of code in different PRs so I wonder...
There was a problem hiding this comment.
I just searched, and it's neither in master, nor in nsdi_skipchain_602.
Although it is nice to add a test maybe we should configure coveralls not to fail if the coverage decreases? |
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This seem to be changes I did on the first timestamp branch. I think it's totally fine to loose some of the history but I don't think this test isn't really neccessary (I forgot to delete it)
NOPE ! Please let's try to have high standards on master when we can. If really we need to merge something with a decreasing coverage, we can still do it anyway and we'll have a warning as a bonus. |
|
OK, fair enough. Coveralls still complains about the coverage decreasing. |
Copyfor copying files