Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dockerized deployment #386

Open
wants to merge 1 commit into
base: c4dt-main
Choose a base branch
from
Open

Conversation

PascalinDe
Copy link
Contributor

includes all the relevant files for the new dockerized deployment, including a helper script to set up/tear down a development environment

@PascalinDe PascalinDe requested review from pierluca and jbsv April 3, 2024 13:50
@PascalinDe PascalinDe self-assigned this Apr 3, 2024
@PascalinDe PascalinDe requested a review from a team as a code owner April 3, 2024 13:50
Copy link
Contributor

@jbsv jbsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks

@PascalinDe
Copy link
Contributor Author

I'll have a look why the test is broken, it seems like there's some problem with the DELA version...

@ineiti
Copy link
Member

ineiti commented May 2, 2024

I'll have a look why the test is broken, it seems like there's some problem with the DELA version...

Yes, it relies on the latest dela with the new protocol names.

@PascalinDe
Copy link
Contributor Author

since the reason the test is failing is not related to this PR, I think it can be merged

@jbsv I'll let you hit the merge button

@ineiti
Copy link
Member

ineiti commented May 3, 2024

since the reason the test is failing is not related to this PR, I think it can be merged

@jbsv I'll let you hit the merge button

Sorry, no, please don't merge. If you do, you put the dedis/d-voting repository in an unstable state. We first need to merge the dela-PR before this PR can be merged.

@edit: didn't see that this goes into c4dt-main, sorry. But before we can merge it into main, dela needs to be updated with our changes.

@jbsv hit merge, please!

@PascalinDe
Copy link
Contributor Author

since the reason the test is failing is not related to this PR, I think it can be merged
@jbsv I'll let you hit the merge button

Sorry, no, please don't merge. If you do, you put the dedis/d-voting repository in an unstable state. We first need to merge the dela-PR before this PR can be merged.

maybe I missed something, but how would this PR put the repository in an unstable state? it's only for a merge onto our branch (c4dt-main) and only contains some documentation, the code for the Docker images and a script - none of which are executed automatically (the Docker images are only build on the main branch by the CI)

also the CI for the tests is already broken on this branch

@ineiti
Copy link
Member

ineiti commented May 6, 2024

@jbsv - just to make sure you saw the edit of my message above: please hit merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants