-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove coverpage to allow long sidebar #243
Conversation
Pull Request Test Coverage Report for Build 4105461650
💛 - Coveralls |
@jbsv how can I see the output ? 😅 |
Kudos, SonarCloud Quality Gate passed!
|
@pierluca, from your local git copy of dela: |
dkg/pedersen/dkg_test.go
Outdated
@@ -1064,8 +1064,6 @@ func getCertified(t *testing.T) (*pedersen.DistKeyGenerator, *pedersen.Response) | |||
} | |||
|
|||
type fakeDKGService struct { | |||
dkgService |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure about this in this PR ? 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
Okay, I've been able to run it. Thanks for the instructions. Couple of points of feedback:
EDIT: I just checked the original, and this change seems to make the navigation bar way uglier overalls.
EDIT: It's also not clear why "introduction" and "Dela" would be separate pages, as the introduction is basically pointless to someone browsing the documentation, without going into "Dela".
|
Related to #236, here is an attempt to improve browsing the DELA doc page.