Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup test #37

Merged
merged 3 commits into from
Apr 16, 2020
Merged

Cleanup test #37

merged 3 commits into from
Apr 16, 2020

Conversation

Gilthoniel
Copy link
Contributor

No description provided.

@Gilthoniel Gilthoniel added the enhancement New feature or request label Apr 16, 2020
@Gilthoniel Gilthoniel self-assigned this Apr 16, 2020
@Gilthoniel Gilthoniel requested a review from nkcr April 16, 2020 08:49
@Gilthoniel Gilthoniel added the R4M 🚀 The PR is ready to be reviewed and merged label Apr 16, 2020
nkcr
nkcr reviewed Apr 16, 2020
View reviewed changes
Copy link
Contributor

@nkcr nkcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious: is it planed to test internal/testing/fake/mod.go? For me that wouldn't be necessary, as long as we keep in mind that someone changing a small xerrors.New("faaake error") would make half test fail.

cosi/flatcosi/mod_test.go Outdated Show resolved Hide resolved
@nkcr
Address nkcr's comment
b2db7ae 
Co-Authored-By: Noémien Kocher <nkcr.je@gmail.com>
@Gilthoniel
Copy link
Contributor Author

It's not in the top list of priorities but it definitely should be, yes.

@Gilthoniel Gilthoniel requested a review from nkcr April 16, 2020 14:25
@nkcr nkcr merged commit 4b756f2 into master Apr 16, 2020
@Gilthoniel Gilthoniel deleted the cleanup_test branch April 16, 2020 14:30
bbjubjub2494 pushed a commit to bbjubjub2494/dela that referenced this pull request Aug 3, 2024
@nkcr
Merge pull request dedis#37 from dedis/cleanup_test
257c866 
Cleanup test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkcr nkcr nkcr approved these changes

Assignees

@Gilthoniel Gilthoniel

Labels
enhancement New feature or request R4M 🚀 The PR is ready to be reviewed and merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gilthoniel @nkcr