Rate control 273 #483
Rate control 273 #483
Conversation
cache.go
Outdated
| // defined at the cache creation | ||
| // The implementation is robust against concurrent call | ||
| type cacheTTL struct { | ||
| entries map[interface{}]*cacheTTLEntry |
There was a problem hiding this comment.
Typically it's better to use value types instead of pointer types like interface{} as keys. that's because two different pointers might have the same value which will create duplicates in the cache. The functions where Set/Get is called like RegisterRoster and RegisterTree often take parameters that originate from the network. So, if Set gets called, then Get gets called somewhere else on something that has the same value but a different address, then the cache will miss.
There was a problem hiding this comment.
I think RosterID and TreeID are, at the end of the day, array types, so maybe setting the key to [32]byte will work.
There was a problem hiding this comment.
sorry, my bad. I did not notice that cacheTTL is like an abstract class. the entries are concrete type when implemented.
There was a problem hiding this comment.
so as discussed and to reduce confusion I changed the key to be of UUID type (instead of the raw type to avoid breaking changes from the package)
|
Is it possible to use your new cache structure for |
|
Yes totally, I'm going to move the logic |
This PR improves caching of Tree and Roster in the overlay implementation by adding an expiration to cached entries.
Fixes #273